Repository navigation
Fix div nesting bug in open-source program-support block - #46
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/open-source/, the Program Support section's container</div>closed inside the{{#foreach}}loop instead of after it, producing malformed unclosed-div HTML for every matched page beyond the first.</div>to after{{/foreach}}{{/get}}so the container wraps the full loop output once, regardless of how many pages match thehash-oss-program-supporttag.Context
Found while investigating broken layout/styles on https://rubycentral.org/open-source/. That page currently has two other problems, tracked separately (not code fixes, so out of scope here):
app.cssdeployed to Ghost is stale/mismatched vs.main(missing#modern,.mission-and-vision,.program-support,.sponsors__inner, etc.) — needs a redeploy via thedeploy-theme.ymlpipeline.This PR only fixes the template bug, which independently corrupts the DOM once the duplicate-page issue above is present (and is worth fixing regardless).
Test plan
npm run build) and confirm#modern .program-supportrenders as a single well-formed<div class="container program-support">...</div>block with no stray closing tags, both when 1 page matches the tag and when multiple do.